Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has_valid_clone and has_valid_webhook to ProjectAdminSerializer #4107

Merged
merged 2 commits into from May 24, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented May 17, 2018

This is needed to be able to update the has_valid_clone field from the UpdateDocsTask when a build is triggered but also it's good information to have over the API.

Closes #4106

This is needed to be able to update the `has_valid_clone` field from
the UpdateDocsTask when a build is triggered but also it's good
information to have over the API.
@humitos
Copy link
Member Author

@humitos humitos commented May 22, 2018

We could completely remove this field also, since it's not used anywhere and currently our db says that none project as a valid clone 😆

Copy link
Member

@ericholscher ericholscher left a comment

👍 -- think we need to fix the API response in the test, and I'm good to merge it.

@humitos humitos merged commit d72972b into master May 24, 2018
1 check passed
@humitos humitos deleted the humitos/api/has-valid-clone branch May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants