Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sync _static dir for search builder #4120

Merged
merged 2 commits into from May 21, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented May 21, 2018

Closes #3799

Was a little hard to figure out testing here, I think we don't have tests for the other builders 馃

@stsewd
Copy link
Member Author

@stsewd stsewd commented May 21, 2018

I did a manual test too :)

shutil.copytree(
self.old_artifact_path,
self.target,
ignore=shutil.ignore_patterns(*self.ignore_patterns)
Copy link
Member Author

@stsewd stsewd May 21, 2018

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 21, 2018

This is an elegant solution to this problem. 鉂わ笍

1 similar comment
@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 21, 2018

This is an elegant solution to this problem. 鉂わ笍

@ericholscher ericholscher merged commit 290ad5b into readthedocs:master May 21, 2018
1 check passed
@stsewd stsewd deleted the dont-sync-static-json-builder branch May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants