Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth/services: correct error handling in paginate #4134

Merged
merged 1 commit into from May 24, 2018

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented May 23, 2018

the else code was dead code as the code in the try block already
returned. Instead return an empty list when it is needed.

the else code was dead code as the code in the try block already
returned. Instead return an empty list when it is needed.
stsewd
stsewd approved these changes May 23, 2018
Copy link
Member

@stsewd stsewd left a comment

Thanks!

@ericholscher ericholscher merged commit 2f5ae97 into readthedocs:master May 24, 2018
1 check passed
@xrmx xrmx deleted the paginatealwaysreturn branch May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants