Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore migrations from coverage report #4141

Merged
merged 1 commit into from May 24, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented May 24, 2018

This ignores the files from the migration folders, so we have a better coverage report. In the future would be nice to integrate coverage into the CI pipeline.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 24, 2018

Yea, I tried to setup coveralls at one point, but might be worth trying again. There's a few free for OSS hosted services.

Loading

@ericholscher ericholscher merged commit c39c770 into readthedocs:master May 24, 2018
1 check passed
Loading
@stsewd stsewd deleted the ignore-migrations-coverage branch May 24, 2018
@humitos
Copy link
Member

@humitos humitos commented May 24, 2018

This is probably a good file for the common repo: https://github.com/rtfd/readthedocs-common

Loading

@stsewd
Copy link
Member Author

@stsewd stsewd commented May 24, 2018

We could also use this inside tox itself, but due to we use chdir it doesn't work (weird). I'll be moving this later (at least now I know it works p:)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants