Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS override that doesn't exist. #4165

Merged
merged 6 commits into from May 30, 2018
Merged

Remove CSS override that doesn't exist. #4165

merged 6 commits into from May 30, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 30, 2018

Also remove static path file.

This also fixes a bug that was causing logging to not be happening in Sphinx. This now properly shows errors, so that we can fix them.

Also remove static path file,
and run our tests with warnings enabled since we can now.
@ericholscher ericholscher requested a review from stsewd May 30, 2018
@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented May 30, 2018

This was on my list so I'm glad you did it! 👍

stsewd
stsewd approved these changes May 30, 2018
docs/conf.py Outdated
@@ -71,14 +71,11 @@
gettext_compact = False

html_theme = 'sphinx_rtd_theme'
html_static_path = ['_static']
#html_static_path = ['_static']
Copy link
Member

@stsewd stsewd May 30, 2018

A space after the #? Just being a little nitpick about the style p:

Copy link
Member Author

@ericholscher ericholscher May 30, 2018

👍

@ericholscher ericholscher merged commit f083818 into master May 30, 2018
1 check passed
@stsewd stsewd deleted the remove-css-override branch May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants