Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing gitignore item for ES testing #4193

Merged
merged 1 commit into from Jun 6, 2018
Merged

Add missing gitignore item for ES testing #4193

merged 1 commit into from Jun 6, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 6, 2018

No description provided.

@ericholscher ericholscher requested a review from safwanrahman Jun 6, 2018
@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Jun 6, 2018

have you run the script locally?

Loading

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Jun 6, 2018

Yea, I ran it to get ES setup on the same version to test against :)

Loading

Copy link
Member

@safwanrahman safwanrahman left a comment

Looks cool! I had never run the script locally so could not catch this.
r+

Loading

@safwanrahman safwanrahman merged commit 9dbb768 into master Jun 6, 2018
1 check passed
Loading
@stsewd stsewd deleted the add-ignore branch Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants