Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggering a build for a skipped project #4255

Merged
merged 1 commit into from Jun 19, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jun 18, 2018

I introduced a bug when doing the rework of trigger_build and prepare_build.

This PR skip the build properly when Project.skip=True keeping the same behavior.

@humitos humitos requested a review from Jun 18, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks like a good fix. It feels a bit messy because of the None feeling magical, but probably fine for now. I wonder about raising an exception and handling it to be more explicit, but probably fine for now.

@humitos
Copy link
Member Author

@humitos humitos commented Jun 18, 2018

Agree. This needs more rework but didn't want to keep this bug around now. I'll open an issue for this.

@ericholscher ericholscher merged commit 5ea9c44 into master Jun 19, 2018
1 check passed
@stsewd stsewd deleted the humitos/project/skip-fix branch Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants