Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #4206 from FlorianKuckelkorn/fix/pip-breaking-change" #4261

Merged
merged 1 commit into from Jun 19, 2018

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jun 18, 2018

This reverts commit b6de0c4, reversing
changes made to 08beab1.

Ref #4206

This breaks because packages with no binary fail to install. This doesn't seem
to be the functionality that we want. --use-wheel used a wheel and backed
down to source packages

…ing-change"

This reverts commit b6de0c4, reversing
changes made to 08beab1.
@agjohnson agjohnson requested a review from Jun 18, 2018
@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Jun 18, 2018

The underlying change should go back to design decision.

Copy link
Member

@ericholscher ericholscher left a comment

I believe we can just remove this line, and newer pip will use the wheel if it exists. I should have tested this fix better locally :(

@humitos
Copy link
Member

@humitos humitos commented Jun 19, 2018

Agree. Santos found this #4262 (comment)

I think we should just remove that option and we will be safe.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 19, 2018

Merging this, but agreed we should open another removing it.

@ericholscher ericholscher merged commit 017f581 into master Jun 19, 2018
1 check passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jun 19, 2018

Opened #4269

@agjohnson agjohnson deleted the agj/hotfix-pip10 branch Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants