Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "npm run lint" from tox #4312

Merged
merged 2 commits into from Jul 5, 2018
Merged

Use "npm run lint" from tox #4312

merged 2 commits into from Jul 5, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jun 29, 2018

Gulp doesn't need to be globally installed or the PATH tweaked in order to run eslint tests. The NPM scripts will use the correct gulp installed as part of npm install.

Copy link
Member

@ericholscher ericholscher left a comment

Looks good, if not kind of magical.

Copy link
Contributor

@agjohnson agjohnson left a comment

Looks good! Thanks for the update!

@agjohnson agjohnson merged commit b0810e0 into master Jul 5, 2018
1 check passed
@agjohnson agjohnson deleted the davidfischer/tox-use-npm-run branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants