Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the UID from the GA measurement protocol #4347

Merged
merged 1 commit into from Jul 12, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jul 9, 2018

This is a workaround for a bug in the GA measurement protocol. Specifically it causes events to only show up in real-time reports and not regular reports.

As a result of this workaround, there will be no handling of session data and all users will be treated as "new" as opposed to returning. Another possible workaround is to use the cid parameter which would involve constructing a deterministic UUID.

@davidfischer davidfischer requested a review from ericholscher Jul 9, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Huh, interesting. Seems like a pretty bad bug, and surprising that it's been open for years. I guess that's the downside of doing non-standard GA things.

@davidfischer davidfischer merged commit dfdf4df into master Jul 12, 2018
1 check passed
@davidfischer davidfischer deleted the davidfischer/ga-workaround-uid branch Jul 12, 2018
@@ -57,9 +57,6 @@ def anonymize_user_agent(user_agent):

def send_to_analytics(data):
"""Sends data to Google Analytics"""
if data.get('uip') and data.get('ua'):
data['uid'] = generate_client_id(data['uip'], data['ua'])
Copy link
Contributor Author

@davidfischer davidfischer Jul 17, 2018

Removing this makes nothing show up in Google Analytics which is even worse. It looks like we want the Client ID (cid).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants