Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for 'options' in update_repos command #4373

Merged
merged 2 commits into from Jul 23, 2018
Merged

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jul 16, 2018

Fixes a bug introduced in #4345 (comment)

@@ -57,7 +57,8 @@ def handle(self, *args, **options):
record = options['record']
force = options['force']
version = options['version']
if args:

if options:
Copy link
Member

@stsewd stsewd Jul 16, 2018

Options already have some keys (record, force, etc). I think we want to skip this and just do for slug in options.get('slugs', []): ...

Copy link
Member Author

@humitos humitos Jul 16, 2018

Thanks! Fixed.

@humitos humitos force-pushed the humitos/command/update_repos branch from c935ae8 to 0c17b42 Jul 16, 2018
@agjohnson agjohnson added this to the Development improvements milestone Jul 20, 2018
@humitos
Copy link
Member Author

@humitos humitos commented Jul 23, 2018

Merging since it's not a big change and it's annoying when importing project to debug :D

@humitos humitos merged commit 8a34164 into master Jul 23, 2018
1 check passed
@humitos humitos deleted the humitos/command/update_repos branch Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants