Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static: use modern getJSON callbacks #4382

Merged
merged 2 commits into from Oct 31, 2018

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Jul 17, 2018

Use done() and fail() instead of complete() and success() that got
removed in jquery 3.0.

@stsewd
Copy link
Member

@stsewd stsewd commented Jul 18, 2018

@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Jul 18, 2018

@stsewd i've not regerated them on purpose to avoid issues with review / merge latency. If you are fine with the PR i can build the static files.

@stsewd
Copy link
Member

@stsewd stsewd commented Jul 18, 2018

@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Jul 18, 2018

Are deprecated since 1.5 or 1.6 can't remember.

@agjohnson agjohnson added this to the Refactoring milestone Jul 20, 2018
@xrmx xrmx force-pushed the moderngetjsonapi branch from 94e22af to 880859c Jul 24, 2018
@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Jul 24, 2018

Updated branch with rebuilt static files

@xrmx xrmx force-pushed the moderngetjsonapi branch from 880859c to f78230a Aug 14, 2018
@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Aug 14, 2018

Updated PR to fix merge conflict

@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Aug 21, 2018

New build conflicts, what about starting to open PR with only the source changed and have a commiter rebuild the static files?

@stsewd
Copy link
Member

@stsewd stsewd commented Aug 21, 2018

I was thinking about that too, I don't remember what the core team said about that

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

Tested this locally and it looks good. 👍

Use done() and fail() instead of complete() and success() that got
removed in jquery 3.0.
@ericholscher ericholscher merged commit c709316 into readthedocs:master Oct 31, 2018
1 check passed
@codecov
Copy link

@codecov codecov bot commented Oct 31, 2018

Codecov Report

Merging #4382 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4382   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files         158      158           
  Lines       10019    10019           
  Branches     1265     1265           
=======================================
  Hits         7636     7636           
  Misses       2039     2039           
  Partials      344      344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants