Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SNI support for API HTTPS endpoint #4423

Merged
merged 2 commits into from Aug 2, 2018
Merged

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jul 24, 2018

This allows us to use a production internal loadbalancer without forcing
readthedocs.org resolves to the internal loadbalancer.

This allows us to use a production internal loadbalancer without forcing
`readthedocs.org` resolves to the internal loadbalancer.
@agjohnson agjohnson requested a review from Jul 24, 2018
@agjohnson agjohnson added this to the Azure migration milestone Jul 24, 2018
Copy link
Contributor

@davidfischer davidfischer left a comment

This seems fine. Here's the relevant docs from requests-toolbelt.

Loading

@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Jul 25, 2018

Updated this, it worked for api v1, but needed some more changes for api v2.

Loading

@agjohnson agjohnson merged commit 6f02839 into master Aug 2, 2018
1 check passed
Loading
@agjohnson agjohnson deleted the agj/add-api-client-ssl-sni branch Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants