Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #4092: Remove unused field from Project model #4431

Merged
merged 3 commits into from Oct 31, 2018
Merged

Fix for issue #4092: Remove unused field from Project model #4431

merged 3 commits into from Oct 31, 2018

Conversation

@Alig1493
Copy link
Contributor

@Alig1493 Alig1493 commented Jul 26, 2018

Close #4092

@stsewd
Copy link
Member

@stsewd stsewd commented Jul 26, 2018

Thanks for looking at this, I think you made this PR with an old version of the repo (that's why the conflicts), do you mind opening a new PR with an updated branch?. Let me know if you need help to do so.

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Jul 27, 2018

@Alig1493 You should rebase on master and fix the merge conflicts.

@Alig1493
Copy link
Contributor Author

@Alig1493 Alig1493 commented Jul 27, 2018

@stsewd @safwanrahman I'll look into it.

@Alig1493
Copy link
Contributor Author

@Alig1493 Alig1493 commented Jul 28, 2018

@stsewd @safwanrahman I've looked into it to the best of my ability. Would you like to take a look into it?

stsewd
stsewd approved these changes Jul 29, 2018
Copy link
Member

@stsewd stsewd left a comment

LGTM, thanks!

model_name='project',
name='comment_moderation',
),
migrations.AlterField(
Copy link
Member

@safwanrahman safwanrahman Jul 29, 2018

Why this Altering?

Copy link
Member

@stsewd stsewd Jul 29, 2018

The rest of alters are from missing migrations (just changes in help text or options) #4201

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Jul 30, 2018

Looks good. r+

@agjohnson agjohnson added this to the Cleanup milestone Aug 2, 2018
Copy link
Member

@humitos humitos left a comment

Thanks! This looks good to me!

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

Bumped the migration name, and will merge this 👍

@ericholscher ericholscher merged commit c6ee38c into readthedocs:master Oct 31, 2018
1 check passed
@codecov
Copy link

@codecov codecov bot commented Oct 31, 2018

Codecov Report

Merging #4431 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4431      +/-   ##
==========================================
- Coverage   76.21%   76.21%   -0.01%     
==========================================
  Files         158      158              
  Lines       10019    10017       -2     
  Branches     1265     1265              
==========================================
- Hits         7636     7634       -2     
  Misses       2039     2039              
  Partials      344      344
Impacted Files Coverage Δ
readthedocs/projects/models.py 84% <ø> (-0.07%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants