Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: mark more strings for translation #4438

Merged
merged 1 commit into from Oct 31, 2018

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Jul 27, 2018

No description provided.

Copy link
Member

@humitos humitos left a comment

Thanks!

@humitos humitos requested a review from safwanrahman Jul 27, 2018
@humitos
Copy link
Member

@humitos humitos commented Jul 27, 2018

@safwanrahman can you take a look at this file? I know that you were working on the search. These changes don't look too complicated but maybe this file won't exist anymore or similar. You know that :)

@@ -79,7 +79,7 @@ <h5>Version</h5>

{% if facets.taxonomy %}

<h5>Taxonomy</h5>
<h5>{% trans 'Taxonomy' %}</h5>
Copy link
Member

@safwanrahman safwanrahman Jul 27, 2018

This is not needed. as we never did Taxonomy and it will be removed

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Jul 27, 2018

thanks @humitos for mentioning me.
This file will exist in the search upgrade, but I am hesitate to merge this before we deploy our new upgraded search. The template is changed in the new search, so I think we can hold this PR untill our search_upgrade branch merged into master.

@safwanrahman safwanrahman added this to the Search improvements milestone Jul 27, 2018
@xrmx
Copy link
Contributor Author

@xrmx xrmx commented Jul 27, 2018

Please either merge this now, cherry-pick in your branch, close the pr but don't expect me to respin sometime in the future when some branch will merge, thanks.

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Jul 27, 2018

@xrmx I have added this PR to the search Improvement milestone, so it will not get lost. If you want to merge it now, then you can open the PR against search_upgrade branch.

@safwanrahman safwanrahman changed the base branch from master to search_upgrade Jul 27, 2018
@safwanrahman safwanrahman changed the base branch from search_upgrade to master Jul 27, 2018
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

Gonna merge this, as it's useful, and the search upgrade is blocked currently :(

@ericholscher ericholscher merged commit 9917933 into readthedocs:master Oct 31, 2018
1 check passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

Thanks @xrmx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants