Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port https://github.com/rtfd/readthedocs-build/pull/38/ #4461

Merged
merged 2 commits into from Aug 27, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Aug 2, 2018

The problem was already fixed with the refactor, but anyway I want to add these tests.

Closes #2813

@@ -48,7 +48,7 @@ def test_parse_empty_value():
def test_parse_empty_string_value():
buf = StringIO(u'base: ""')
config = parse(buf)
assert config[0]['base'] is ''
assert config[0]['base'] == ''
Copy link
Member Author

@stsewd stsewd Aug 2, 2018

Copy/paste issue p:

Copy link
Contributor

@agjohnson agjohnson left a comment

LGTM!

@agjohnson agjohnson merged commit fefdea4 into readthedocs:master Aug 27, 2018
1 check passed
@stsewd stsewd deleted the port-rtd-build#38 branch Aug 28, 2018
source_file=str(tmpdir.join('readthedocs.yml')),
)
build.validate()
assert build.requirements_file is None
Copy link
Member Author

@stsewd stsewd Aug 28, 2018

Ups, forgot to rename this to the latest changes, I'll fix this in a couple of minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants