Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom domain clarifications #4514

Merged
merged 2 commits into from Aug 13, 2018
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Aug 13, 2018

For some users with older custom domain setups (eg. CNAME to readthedocs.org), we were not able to issue a certificate for them. While the request to issue certificates retries for a long time, it has been a couple weeks now and they have timed out.

My goal with this PR is to notify those users that they need to re-request a certificate -- by saving the domain object -- in order to get one. Likewise, after #4483 we show the status of the domain on the domain edit screen and I want users to see that which might help uncover issues (eg. CAA, incorrect setup, time out).

Lastly, since things have changed I added a link to the docs from the domain edit screen. This should be removed in the near future (October-ish).

screen shot 2018-08-13 at 1 24 33 pm

- Note about re-requesting certificates
- Note about status on the domain edit screen
- Fix typo
Copy link
Member

@humitos humitos left a comment

👍

Loading

@davidfischer davidfischer merged commit f708e5c into master Aug 13, 2018
1 check passed
Loading
@davidfischer davidfischer deleted the davidfischer/custom-domain-clarification branch Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants