Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize command output when running under DockerBuildEnvironment #4591

Merged
merged 1 commit into from Aug 30, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Aug 30, 2018

In #4552 I fixed this for LocalBuildEnvironment but I forget to do exactly the same for Docker. This is what this commit does.

Closes #3900

In #4552 I fixed this for LocalBuildEnvironment but I forget to do
exactly the same for Docker. This is what this commit does.
@humitos humitos requested a review from Aug 30, 2018
stsewd
stsewd approved these changes Aug 30, 2018
Copy link
Member

@stsewd stsewd left a comment

LGTM

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Aug 30, 2018

Oops, yeah missed that one, huh? LGTM!

@agjohnson agjohnson merged commit a29fea4 into master Aug 30, 2018
1 check passed
@agjohnson agjohnson deleted the humitos/build/sanitize-cmd-output branch Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants