Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ad block nag project issue #4596

Merged
merged 1 commit into from Sep 5, 2018
Merged

Fix ad block nag project issue #4596

merged 1 commit into from Sep 5, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Aug 31, 2018

This fixes an issue with the ad nag where a project is sponsored and the user runs an ad blocker. We know whether a project is ad-free when we build it and we should never show the nag on a sponsored project.

This partially resolves the nag issue in #4595 (I purposefully worded this to not auto-close that issue).

#4329 did not quite correctly fix this issue.

@davidfischer davidfischer requested a review from Aug 31, 2018
Copy link
Contributor

@agjohnson agjohnson left a comment

Looks good to me

@agjohnson agjohnson merged commit 1225551 into master Sep 5, 2018
1 check passed
@agjohnson agjohnson deleted the davidfischer/nag-fix branch Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants