Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mentions of "CNAME" -> custom domain #4627

Merged
merged 2 commits into from Sep 13, 2018
Merged

Conversation

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Sep 10, 2018

CNAME refers to a DNS construct, not an RTD construct. Referring to these as
"custom domain" instead makes this information easier to understand/find.

Also includes some random cleanup of copy around the CNAME -> custom domain
changes.

Also some related cleanup of copy around the CNAME -> custom domain
changes.
@agjohnson agjohnson requested a review from Sep 10, 2018
@agjohnson agjohnson added this to the 2.7 milestone Sep 10, 2018
Copy link
Contributor

@davidfischer davidfischer left a comment

I had one small fix but this looks good.

@@ -65,4 +65,4 @@ We provide full-text search across all of the pages of documentation hosted on o
Alternate Domains
-----------------

We provide support for CNAMEs, subdomains, and a shorturl for your project as well. This is outlined in the :doc:`alternate_domains` section.
We provide support for customer domains, subdomains, and a shorturl for your project as well. This is outlined in the :doc:`alternate_domains` section.
Copy link
Contributor

@davidfischer davidfischer Sep 10, 2018

customer -> custom

CNAMEs add a bit of difficulty,
because at the nginx layer we don't know what documentation to serve.
Custom domains add a bit of difficulty,
because at the Nginx layer we don't know what documentation to serve.
Copy link
Member

@RichardLitt RichardLitt Sep 10, 2018

I think only the company is capitalized. On the nginx website, it is consistently lower-cased.

Copy link
Member

@RichardLitt RichardLitt left a comment

Small change, but LGTM.

@agjohnson agjohnson merged commit 4f1a5dc into master Sep 13, 2018
1 check passed
@agjohnson agjohnson deleted the agj/stop-calling-it-cname branch Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants