Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an explicit ad placement #4647

Merged
merged 2 commits into from Sep 20, 2018
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Sep 19, 2018

This adds the options for projects to opt-in to have an ad placement in a specific spot on their docs by adding a <div id="ethical-ad-placement"></div> in a specific place.

  • For projects where we have a revenue share in place -- something I'm trying to grow -- this allows them to put the ads in a better spot and make more money.
  • This puts projects in control of where ads go.

Future things not in this PR

  • Allow specifying different ad types (eg. text-only, footer ads, etc.). I envision doing this by adding data-ad-type attributes on the <div>. Currently this only does left-navigation ads.

Screenshot

screen shot 2018-09-18 at 4 54 03 pm

@davidfischer davidfischer requested a review from Sep 19, 2018
Copy link
Member

@ericholscher ericholscher left a comment

This has been on my list for a while, letting folks choose how to integrate the ad 👍

We should include docs on this as part of this PR I think -- though perhaps we want to test it before we publish docs on it?

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Sep 19, 2018

We should include docs on this as part of this PR I think -- though perhaps we want to test it before we publish docs on it?

We definitely need docs on this explicit placement. However, I wouldn't mind running a little test before we publish those docs. Right now, I'm not sure I want projects I'm not talking to to use this yet.

@davidfischer davidfischer merged commit fd5704f into master Sep 20, 2018
1 check passed
@davidfischer davidfischer deleted the davidfischer/explicit-ad-placement branch Sep 20, 2018
@humitos
Copy link
Member

@humitos humitos commented Oct 1, 2018

This is a good improvement! I think we should update other places (prospectus, maybe?) where we say that the ads will be at the bottom of the menu list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants