Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad customization docs #4659

Merged
merged 1 commit into from Sep 24, 2018
Merged

Ad customization docs #4659

merged 1 commit into from Sep 24, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Sep 21, 2018

While the docs themselves are a work in progress, I would like a public link to point to for the few people making these customizations.

Relates to #4647

- This is a work in progress
@davidfischer davidfischer requested a review from Sep 21, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

@davidfischer davidfischer merged commit a49a6e7 into master Sep 24, 2018
1 check passed
@davidfischer davidfischer deleted the davidfischer/ad-customization branch Sep 24, 2018
@humitos
Copy link
Member

@humitos humitos commented Oct 1, 2018

It seems that we only have documentation for Sphinx. Isn't this possible in MkDocs yet? Do we care about it? :)

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Oct 1, 2018

It seems that we only have documentation for Sphinx. Isn't this possible in MkDocs yet? Do we care about it? :)

Not yet I'd say. It's definitely a work in progress but in general it will be similar. Override some of the templates and add the div with the appropriate ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants