Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logging #4665

Merged
merged 2 commits into from Oct 2, 2018
Merged

Clean up logging #4665

merged 2 commits into from Oct 2, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Sep 25, 2018

Following up to #3677

@@ -517,16 +514,6 @@ def handle_exception(self, exc_type, exc_value, _):
def record_command(self, command):
command.save()

def _log_warning(self, msg):
# :'(
Copy link
Member Author

@stsewd stsewd Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye sad face :(

Loading

Copy link
Member

@RichardLitt RichardLitt Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He'll still be in our git history. :')

Loading

Copy link
Contributor

@agjohnson agjohnson left a comment

LGTM! We do this in a couple places, but nice to at least refactor this out for now.

Loading

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Oct 2, 2018

Waiting on tests after merge conflict updates, then probably safe to merge this.

Loading

@agjohnson agjohnson merged commit 61165ba into readthedocs:master Oct 2, 2018
1 check passed
Loading
@stsewd stsewd deleted the cleanup-logging branch Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants