Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove search autosync from tests so local tests work #4675

Merged
merged 7 commits into from Sep 29, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Sep 28, 2018

This needs additional work to then also fix the travis tests.

Copy link
Member

@stsewd stsewd left a comment

This fixes my tests locally 👍

Loading

@safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Sep 28, 2018

I think it will not work if you want to run the search tests.

Loading

@@ -9,6 +11,7 @@

@pytest.mark.django_db
@pytest.mark.search
@override_settings(ELASTICSEARCH_DSL_AUTOSYNC=True)
Copy link
Member

@safwanrahman safwanrahman Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be used with unittest only! we need to use pytest here

Loading

Copy link
Member Author

@ericholscher ericholscher Sep 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how do you do it with pytest?

Loading

@ericholscher ericholscher merged commit d3ba140 into master Sep 29, 2018
1 check passed
Loading
@stsewd stsewd deleted the remove-search-test-sync branch Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants