Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken url on sphinx projects #4696

Merged
merged 3 commits into from Oct 2, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 1, 2018

Fix #4671

@stsewd stsewd requested a review from Oct 1, 2018
params = base_sphinx.get_config_params()
self.assertEqual(
params['conf_py_path'],
'/docs/'
Copy link
Member Author

@stsewd stsewd Oct 1, 2018

not sure what else to test from params.

python_env=python_env,
)

for value, expected in (('conf.py', '/'), ('docs/conf.py', '/docs/')):
Copy link
Member Author

@stsewd stsewd Oct 1, 2018

We can't use pytests parametrize here :(

@stsewd
Copy link
Member Author

@stsewd stsewd commented Oct 1, 2018

Travis failure is for search stuff

Copy link
Contributor

@agjohnson agjohnson left a comment

LGTM!

@agjohnson agjohnson merged commit 4c2fe1e into readthedocs:master Oct 2, 2018
1 check passed
@stsewd stsewd deleted the fix-broken-url-sphinx branch Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants