Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging verbosity on syncer failure #4717

Merged
merged 1 commit into from Oct 9, 2018
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 3, 2018

We get a ton of these,
but never look at them.
I don't really know if we can fix this,
but lets stop spamming Sentry

We get a ton of these,
but never look at them.
I don't really know if we can fix this,
but lets stop spamming Sentry
@stsewd
Copy link
Member

@stsewd stsewd commented Oct 3, 2018

I believe we are tracking the failures here #4428

@ericholscher ericholscher requested a review from Oct 6, 2018
humitos
humitos approved these changes Oct 9, 2018
Copy link
Member

@humitos humitos left a comment

I'm fine with this change.

I've been debugging this some months ago and I didn't find how to solve it. The issue that Santos linked showed what I found.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 9, 2018

Hopefully a lot of this will be solved by uploading assets to blob storage instead of rsync'ing, but I believe it's mostly HTML that fails, so shrug.

@ericholscher ericholscher merged commit c38efc8 into master Oct 9, 2018
1 check passed
@stsewd stsewd deleted the less-noisy-syncers branch Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants