Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply the Elastic Search upgrade to master #4722

merged 24 commits into from Jan 24, 2019

Reapply the Elastic Search upgrade to master #4722

merged 24 commits into from Jan 24, 2019


Copy link

@ericholscher ericholscher commented Oct 4, 2018

This is a revert of the revert, so that we have a place to track the search code.
We should also push any testing for performance and other tweaks here.

This is a squashed commit of all previous changes.
@ericholscher ericholscher force-pushed the search-reapply branch 2 times, most recently from b3f24b1 to 12de58b Jan 22, 2019

class TestXSS(object):
Copy link

@stsewd stsewd Jan 24, 2019

No need to inheritance from object anymore

@ericholscher ericholscher merged commit ca4e674 into master Jan 24, 2019
1 check passed
Copy link
Member Author

@ericholscher ericholscher commented Jan 24, 2019

Congrats @safwanrahman!

@delete-merged-branch delete-merged-branch bot deleted the search-reapply branch Jan 24, 2019
@safwanrahman safwanrahman added this to Backlog in Search update via automation Jan 24, 2019
Copy link

@safwanrahman safwanrahman commented Jan 24, 2019

😄 Thanks @ericholscher for mentoring.
Glad that it has been merged again to master and have deployed to production!

@safwanrahman safwanrahman moved this from Backlog to Done in Search update Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No open projects
Search update
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants