Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way of using login_required decorator #4723

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Oct 4, 2018

Fixes #4692

stsewd
stsewd approved these changes Oct 4, 2018
Copy link
Member

@stsewd stsewd left a comment

LGTM, thanks!

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 25, 2018

@dojutsu-user can you please resolve the conflicts? create_profile was removed, so we only need login_required on edit_profile.

@codecov
Copy link

@codecov codecov bot commented Oct 25, 2018

Codecov Report

Merging #4723 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #4723   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files         158      158           
  Lines       10034    10034           
  Branches     1267     1267           
=======================================
  Hits         7652     7652           
  Misses       2039     2039           
  Partials      343      343
Impacted Files Coverage Δ
readthedocs/profiles/views.py 86.44% <100%> (ø) ⬆️

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Oct 25, 2018

@stsewd I have resolved the conflicts.
Please review.

stsewd
stsewd approved these changes Oct 25, 2018
@ericholscher ericholscher merged commit 77f4eb8 into readthedocs:master Oct 31, 2018
3 checks passed
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

🎉 Thanks @dojutsu-user

@dojutsu-user dojutsu-user deleted the login-required-decorator branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants