Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_vcs_repo by moving it to the Mixin #4727

Merged
merged 2 commits into from Oct 6, 2018
Merged

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 4, 2018

No description provided.

@ericholscher ericholscher requested a review from Oct 4, 2018
humitos
humitos approved these changes Oct 4, 2018
Copy link
Member

@humitos humitos left a comment

This should fix the problem that we just noted in latest deploy.

@humitos
Copy link
Member

@humitos humitos commented Oct 4, 2018

There was a timeout error on one of the search tests. I restarted the job but it should be fine.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 4, 2018

THis is deployed and fixed the error. 👍

stsewd
stsewd approved these changes Oct 4, 2018
Copy link
Member

@stsewd stsewd left a comment

Sorry for breaking this :( I think I missed to test this after a rebase/merge

@ericholscher ericholscher merged commit d1c8c86 into master Oct 6, 2018
1 check passed
@stsewd stsewd deleted the fix-get_vcs_repo branch Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants