Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /cname endpoint #4731

Merged
merged 1 commit into from Oct 16, 2018
Merged

Remove /cname endpoint #4731

merged 1 commit into from Oct 16, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 4, 2018

This isn't used or documented, it was added here 3cada1d

This should be merged after #4730
Related #1991 (comment)

@@ -65,7 +65,6 @@
function_urls = [
url(r'embed/', core_views.embed, name='embed'),
Copy link
Member Author

@stsewd stsewd Oct 4, 2018

This one isn't used either, and it doesn't work

Copy link
Member

@ericholscher ericholscher Oct 16, 2018

Yea, we should kill this. We have the embed in our ext repo that actually does work:

https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/urls.py#L117

Copy link
Member Author

@stsewd stsewd Oct 16, 2018

I opened #4768

def cname_to_slug(host):
# TODO: remove
Copy link
Member Author

@stsewd stsewd Oct 4, 2018

Need to remove this after #4730

Copy link
Member

@ericholscher ericholscher left a comment

I think this is actually good to ship prior to removing the middleware logic. I greped logs and it isn't being used anywhere.

@@ -65,7 +65,6 @@
function_urls = [
url(r'embed/', core_views.embed, name='embed'),
Copy link
Member

@ericholscher ericholscher Oct 16, 2018

Yea, we should kill this. We have the embed in our ext repo that actually does work:

https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/urls.py#L117

@stsewd stsewd mentioned this pull request Oct 16, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Oct 16, 2018

I just wanted to do all the removal here p: there is nothing blocking this, I can do the removal in the other PR

@stsewd stsewd merged commit d11402d into readthedocs:master Oct 16, 2018
1 check passed
@stsewd stsewd deleted the remove-unused-endpoint branch Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants