Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade theme media to 0.4.2 #4734

Merged
merged 1 commit into from Oct 6, 2018
Merged

Upgrade theme media to 0.4.2 #4734

merged 1 commit into from Oct 6, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 5, 2018

No description provided.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 5, 2018

Is this still necessary, now that we're not injecting overrides into the theme?

@ericholscher ericholscher requested a review from Oct 5, 2018
@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Oct 5, 2018

Is this still necessary, now that we're not injecting overrides into the theme?

It is not necessary.

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Oct 5, 2018

I think projects that haven't been built in a while would still be requesting our override files though. Did we address that yet?

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Oct 5, 2018

I think projects that haven't been built in a while would still be requesting our override files though. Did we address that yet?

Projects that haven't been built with the new theme will still request the files from assets.readthedocs.org. However, they are built with the old theme so they should request the old theme's files. If they were built with the new theme, they will get the new theme's files in their built artifacts.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 6, 2018

👍

@ericholscher ericholscher merged commit f548985 into master Oct 6, 2018
1 check passed
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 6, 2018

Opened readthedocs/sphinx_rtd_theme#684 to remove the instructions to do it.

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Oct 6, 2018

I don't think we wanted to merge this.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 6, 2018

Ha yea, I hit the wrong button :(

@stsewd stsewd deleted the upgrade-theme-0.4.2 branch Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants