Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make storage syncers extend from a base class #4742

Merged
merged 1 commit into from Oct 16, 2018

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Oct 10, 2018

It doesn't love that a new positional argument was added in a subclass. I'm not sure if there's a better way to make this work in our lint setup.

@davidfischer davidfischer requested a review from Oct 10, 2018
Copy link
Member

@humitos humitos left a comment

Changes look good!

I don't really care about the lint problem. Your solution with the comment is fine to me.

@davidfischer davidfischer merged commit 5b5edab into master Oct 16, 2018
1 check passed
@davidfischer davidfischer deleted the davidfischer/storage-syncers branch Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants