Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an OSX issue with the test suite #4748

Merged
merged 1 commit into from Oct 12, 2018
Merged

Conversation

@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Oct 11, 2018

There was a change which causes the symlink test suite to fail on OSX.

The problem is caused by:

  • tempfile.mkdtemp returns a path under /var/folders
  • By default on OSX /var is a symlink to /private/var
  • As a result, os.path.realpath(TEMP_SITE_ROOT) != TEMP_SITE_ROOT and the expected paths don't match here

I'm running OSX 10.13.16.

@davidfischer davidfischer requested a review from Oct 11, 2018
Copy link
Member

@humitos humitos left a comment

👍

@humitos humitos merged commit ab2b0c6 into master Oct 12, 2018
1 check passed
@humitos humitos deleted the davidfischer/fix-osx-realpath branch Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants