Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unexpected error message when build fails #4754

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Oct 13, 2018

Fixes #4751

@RichardLitt
Copy link
Member

@RichardLitt RichardLitt commented Oct 15, 2018

Thanks for your first PR, @dojutsu-user! One of the maintainers will get to this soon.

Copy link
Member

@humitos humitos left a comment

I left a comment for the English grammar.

If you think it's acceptable, we need to do the same in the other two places.

'Please report this to us with your build id ({build_id}).',
'Please try again later. '
'However, if this problem persists, '
'please report to us with your build id ({build_id}).',
Copy link
Member

@humitos humitos Oct 15, 2018

I said "please report this to us".

I'm not sure if that was important for the grammar, but I just wanted to mention it.

Copy link
Member Author

@dojutsu-user dojutsu-user Oct 15, 2018

okay.... that looks more good to me too.

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Oct 31, 2018

@humitos I have corrected the grammar. Please review

humitos
humitos approved these changes Nov 1, 2018
Copy link
Member

@humitos humitos left a comment

Thanks!

This is ready to be merged from my point of view!

@humitos humitos requested a review from davidfischer Nov 1, 2018
@humitos
Copy link
Member

@humitos humitos commented Nov 1, 2018

I'm requesting @davidfischer eyes since he is better than myself with English grammar and communication.

@RichardLitt
Copy link
Member

@RichardLitt RichardLitt commented Nov 1, 2018

Looks fine to me. :)

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 1, 2018

💯 Thanks!

@ericholscher ericholscher merged commit fb1fef9 into readthedocs:master Nov 1, 2018
1 check passed
@dojutsu-user dojutsu-user deleted the change-error-msg-when-build-failed branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants