Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run travis on release branches #4763

Merged
merged 1 commit into from Oct 23, 2018
Merged

Run travis on release branches #4763

merged 1 commit into from Oct 23, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 16, 2018

No description provided.

@ericholscher ericholscher requested a review from Oct 16, 2018
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 23, 2018

ping @rtfd/core

Loading

@humitos
Copy link
Member

@humitos humitos commented Oct 23, 2018

I'm not sure to understand when these branches will run the tests?

I suppose that on each merge performed on any of these branches, test will run. If my supposition is correct, feel free to merge.

On the other hand, where this will be informed to us in case of failing?

Loading

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 23, 2018

I suppose that on each merge performed on any of these branches, test will run. If my supposition is correct, feel free to merge.

Yep.

On the other hand, where this will be informed to us in case of failing?

Just in email, I believe to the person who creates the commit.

Loading

@ericholscher ericholscher merged commit 345935c into master Oct 23, 2018
1 check passed
Loading
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 23, 2018

Merged, will revisit if we have any issues. 👍

Loading

@stsewd stsewd deleted the run-travis-on-rel branch Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants