Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade logs from debug on middleware #4769

Merged
merged 1 commit into from Oct 17, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 16, 2018

Ref #4730 (comment)

@@ -107,17 +107,17 @@ def process_request(self, request):
slug = cname_to_slug(host)
cache.set(host, slug, 60 * 60)
# Cache the slug -> host mapping permanently.
log.debug(LOG_TEMPLATE.format(
log.info(LOG_TEMPLATE.format(
Copy link
Member

@humitos humitos Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one info for some particular reason?

Loading

Copy link
Member Author

@stsewd stsewd Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only happens when caching the slug from a cname, doesn't feel like this should be a warning. The other logs are the important part

Loading

Copy link
Member

@ericholscher ericholscher left a comment

Let's ship this, and see how much we're dealing with this in prod. 👍

Loading

@ericholscher ericholscher merged commit 8f6776c into readthedocs:master Oct 17, 2018
1 check passed
Loading
@stsewd stsewd deleted the upgrade-logs-middleware branch Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants