Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the slug generated is valid before importing a project #4780

Merged
merged 2 commits into from Oct 22, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Oct 18, 2018

Very small PR that to avoid importing invalid project names.

@humitos humitos requested a review from Oct 18, 2018
stsewd
stsewd approved these changes Oct 18, 2018
}
form = ProjectBasicsForm(initial)
self.assertFalse(form.is_valid())

Copy link
Member

@stsewd stsewd Oct 18, 2018

We should check that the error really comes from name

Copy link
Member Author

@humitos humitos Oct 18, 2018

yeah, you are right.

In fact, I forget to add the rest of the fields in the initial data.

@humitos humitos merged commit c764af6 into master Oct 22, 2018
1 check passed
@humitos humitos deleted the humitos/import/notslug branch Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants