Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help_text in the form for adopting a project #4781

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Oct 18, 2018

Fixes #4777

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Oct 18, 2018

@stsewd Please review

Copy link
Member

@stsewd stsewd left a comment

LGTM, but I'd left the approve to someone with more english experience to see if the message is right

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Oct 18, 2018

@stsewd Thanks.
Also, as @humitos pointed out in comment #431004142, it is not enough for the user to understand as to what must be entered in the field, so are there any suggestions on this?

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

This is at least an improvement. We can fix it up later.

@ericholscher ericholscher merged commit dedcaee into readthedocs:master Oct 31, 2018
1 check passed
@dojutsu-user dojutsu-user deleted the add-help-text-adopting-project branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants