Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin missing dependency for the MkDocs guide compatibility #4798

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Oct 23, 2018

Today I realize that it's better to PIN this "just in case" that leave it there.

If we pin the markdown we can still use the old way to define extensions. Yay!

@humitos humitos requested a review from Oct 23, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 23, 2018

Codecov Report

Merging #4798 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4798   +/-   ##
=======================================
  Coverage   76.22%   76.22%           
=======================================
  Files         158      158           
  Lines       10025    10025           
  Branches     1264     1264           
=======================================
  Hits         7642     7642           
  Misses       2039     2039           
  Partials      344      344

@humitos humitos merged commit 7b47841 into master Oct 24, 2018
3 checks passed
@humitos humitos deleted the humitos/guides/mkdocs-pinned-dependency branch Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants