Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for multiple configurations in one file #4800

Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 24, 2018

close #4705

@stsewd stsewd force-pushed the remove-support-for-mult-confs branch from 8a18c3a to cc9eab1 Oct 24, 2018
@stsewd
Copy link
Member Author

@stsewd stsewd commented Oct 24, 2018

I still need to do a manual check, but I believe this is ready

Loading

@codecov
Copy link

@codecov codecov bot commented Oct 24, 2018

Codecov Report

Merging #4800 into master will decrease coverage by 0.04%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
- Coverage   76.22%   76.18%   -0.05%     
==========================================
  Files         158      158              
  Lines       10025    10014      -11     
  Branches     1264     1261       -3     
==========================================
- Hits         7642     7629      -13     
- Misses       2039     2040       +1     
- Partials      344      345       +1
Impacted Files Coverage Δ
readthedocs/doc_builder/config.py 91.89% <ø> (ø) ⬆️
readthedocs/config/config.py 98% <100%> (-0.04%) ⬇️
readthedocs/config/parser.py 87.5% <80%> (-12.5%) ⬇️

Loading

@stsewd
Copy link
Member Author

@stsewd stsewd commented Oct 24, 2018

I tested this locally, nothing breaks :)

Loading

@stsewd stsewd requested a review from Oct 24, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Looks good to me. I don't fully have the config code in my head, but I think this makes things simpler, which is great.

Loading

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 9, 2018

Let's go ahead and merge this and get it tested locally. I don't think it should effect anyone in prod, but if so we can deal with it when that happens. 🎉

Loading

@ericholscher ericholscher merged commit 1648006 into readthedocs:master Nov 9, 2018
3 checks passed
Loading
@stsewd stsewd deleted the remove-support-for-mult-confs branch Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants