Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of file:// urls in repos during development. #4801

Merged
merged 3 commits into from Nov 1, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 24, 2018

Closes #4061

@codecov
Copy link

@codecov codecov bot commented Oct 24, 2018

Codecov Report

No coverage uploaded for pull request base (master@9917933). Click here to learn what that means.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master    #4801   +/-   ##
=========================================
  Coverage          ?   76.26%           
=========================================
  Files             ?      158           
  Lines             ?     9984           
  Branches          ?     1262           
=========================================
  Hits              ?     7614           
  Misses            ?     2025           
  Partials          ?      345
Impacted Files Coverage Δ
readthedocs/projects/validators.py 78.46% <33.33%> (ø)

Loading

valid_schemes = public_schemes
if allow_private_repos:
valid_schemes += private_schemes
if getattr(settings, 'DEBUG'): # allow `file://` urls in dev
Copy link
Member

@stsewd stsewd Oct 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

Copy link
Member Author

@ericholscher ericholscher Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use git daemon for local dev

Neat.

Loading

@ericholscher ericholscher merged commit 7202e08 into master Nov 1, 2018
3 checks passed
Loading
@stsewd stsewd deleted the allow-local-files-in-dev branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants