Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old code (remove old_div) #4817

Merged
merged 2 commits into from Oct 29, 2018
Merged

Cleanup old code (remove old_div) #4817

merged 2 commits into from Oct 29, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Oct 28, 2018

Remove unused function and update usage of old_div to // instead.

@humitos humitos requested a review from Oct 28, 2018
@humitos humitos added this to the Cleanup milestone Oct 28, 2018
@humitos humitos force-pushed the humitos/cleanup/old-div branch from e26d8f7 to 08a97bd Oct 28, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 28, 2018

Codecov Report

Merging #4817 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4817      +/-   ##
==========================================
- Coverage   76.26%   76.25%   -0.01%     
==========================================
  Files         158      158              
  Lines       10034    10027       -7     
  Branches     1267     1267              
==========================================
- Hits         7652     7646       -6     
+ Misses       2039     2038       -1     
  Partials      343      343
Impacted Files Coverage Δ
readthedocs/core/views/__init__.py 70.14% <ø> (-0.69%) ⬇️
readthedocs/integrations/models.py 82.28% <100%> (-0.11%) ⬇️
readthedocs/gold/models.py 96% <100%> (-0.16%) ⬇️

stsewd
stsewd approved these changes Oct 28, 2018
@humitos humitos merged commit 9b2b17c into master Oct 29, 2018
3 checks passed
@humitos humitos deleted the humitos/cleanup/old-div branch Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants