Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not import the Celery worker when running the Django app #4824

Merged
merged 1 commit into from Oct 31, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Oct 30, 2018

Do not import all the Celery app (which import the Django settings) when it's not needed.

Required by readthedocs/readthedocs-ops#431

@humitos humitos requested a review from Oct 30, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 30, 2018

Codecov Report

Merging #4824 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4824   +/-   ##
=======================================
  Coverage   76.25%   76.25%           
=======================================
  Files         158      158           
  Lines       10027    10027           
  Branches     1267     1267           
=======================================
  Hits         7646     7646           
  Misses       2038     2038           
  Partials      343      343

Copy link
Member

@ericholscher ericholscher left a comment

Looks good.

@humitos humitos merged commit 8c2fda0 into master Oct 31, 2018
3 checks passed
@humitos humitos deleted the humitos/import/celery branch Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants