Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Branding' under the 'Business Info' section and 'Guidelines' on 'Design Docs' #4830

Merged
merged 3 commits into from Oct 31, 2018

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Oct 31, 2018

Final Result
screenshot from 2018-10-31 11-29-29

Related Issue: #3594

@codecov
Copy link

@codecov codecov bot commented Oct 31, 2018

Codecov Report

Merging #4830 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4830      +/-   ##
==========================================
+ Coverage    76.2%   76.21%   +0.01%     
==========================================
  Files         158      158              
  Lines       10022    10019       -3     
  Branches     1265     1265              
==========================================
- Hits         7637     7636       -1     
+ Misses       2041     2039       -2     
  Partials      344      344
Impacted Files Coverage Δ
readthedocs/gold/forms.py 98% <0%> (ø) ⬆️
readthedocs/restapi/client.py 87.09% <0%> (+4.74%) ⬆️

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

This looks good. The ticket mentions adding a reference in the documentation as well, so I think we should add that in this PR as well 👍

@dojutsu-user dojutsu-user changed the title Add 'Branding' under the 'Business Info' section. Add 'Branding' under the 'Business Info' section and 'Guidelines' on 'Design Docs' Oct 31, 2018
@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Oct 31, 2018

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

Great, I've pushed a small copy edit, and merging it 👍

@ericholscher ericholscher merged commit 9d25fd0 into readthedocs:master Oct 31, 2018
1 check was pending
@stsewd stsewd mentioned this pull request Nov 9, 2018
@dojutsu-user dojutsu-user deleted the add-branding-guidelines branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants