Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the project's slug in the dashboard #4834

Merged
merged 3 commits into from Nov 1, 2018
Merged

Show the project's slug in the dashboard #4834

merged 3 commits into from Nov 1, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

This is confusing for users who don't know what a slug is.
We never show the slug to folks,
so when we use it in documentation they don't know what it is.
This is confusing for users who don't know what a slug is.
We never show the slug to folks,
so when we use it in documentation they don't know what it is.
@ericholscher ericholscher changed the title Allow filtering builds by commit. Show the project's slug in the dashboard Oct 31, 2018
@ericholscher ericholscher requested a review from Oct 31, 2018
@@ -17,6 +17,15 @@ <h3>{% trans "Repository" %}</h3>
{% endif %}
{% endblock %}

{% block slug %}
{% with title="Used in URL's and in code to represent the project name" %}
Copy link
Member

@humitos humitos Oct 31, 2018

This should also be translated I suppose.

@codecov
Copy link

@codecov codecov bot commented Oct 31, 2018

Codecov Report

Merging #4834 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4834      +/-   ##
=========================================
+ Coverage   76.33%   76.4%   +0.06%     
=========================================
  Files         158     158              
  Lines        9968    9975       +7     
  Branches     1258    1259       +1     
=========================================
+ Hits         7609    7621      +12     
+ Misses       2018    2015       -3     
+ Partials      341     339       -2
Impacted Files Coverage Δ
readthedocs/gold/forms.py 94.54% <0%> (-3.46%) ⬇️
readthedocs/gold/views.py 66.17% <0%> (ø) ⬆️
readthedocs/restapi/client.py 87.09% <0%> (ø) ⬆️
readthedocs/core/views/__init__.py 71.01% <0%> (+0.86%) ⬆️
readthedocs/projects/models.py 85.5% <0%> (+1.49%) ⬆️

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 31, 2018

Related #4777

@ericholscher ericholscher requested a review from Nov 1, 2018
humitos
humitos approved these changes Nov 1, 2018
@ericholscher ericholscher merged commit 8d659a1 into master Nov 1, 2018
3 checks passed
@stsewd stsewd deleted the show-project-slug branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants