Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all migrations that are missing from model changes #4837

Merged
merged 4 commits into from Nov 1, 2018

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 31, 2018

Fixes #4201

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 31, 2018

What about adding the check for missing migrations on this PR too?

./manage.py makemigrations --check --dry-run

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Oct 31, 2018

I'm still not convinced having a CI check for migrations is a good idea. It just feels like we're going to accumulate a ton of migrations, and have issues with them conflicting :(

But I'm 👍 on getting it in there and seeing how it plays out.

@ericholscher ericholscher requested a review from Oct 31, 2018
stsewd
stsewd approved these changes Oct 31, 2018
@ericholscher ericholscher merged commit c2fc750 into master Nov 1, 2018
1 check passed
@stsewd stsewd deleted the update-migration branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants