Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing config v2 on our project #4838

Merged
merged 3 commits into from Nov 2, 2018

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Oct 31, 2018

We'll need to activate the ALLOW_V2_CONFIG_FILE flag on the project

fail_on_warning: true
python:
install:
requirements: requirements.txt
Copy link
Member Author

@stsewd stsewd Oct 31, 2018

We need to change this later, when #4740 is deployed

Copy link
Member

@ericholscher ericholscher Nov 1, 2018

I wonder if we should try and deploy this first.

Copy link
Member Author

@stsewd stsewd Nov 1, 2018

Yeah, I was thinking the same. But I'm curious to see how this plays on production too 😁

Copy link
Member

@ericholscher ericholscher Nov 2, 2018

Cool, lets ship it then :)

Copy link
Member

@ericholscher ericholscher left a comment

👍 to dogfooding :)

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 1, 2018

Flag is now set.

@ericholscher ericholscher merged commit 089e5fa into readthedocs:master Nov 2, 2018
1 check passed
@stsewd stsewd deleted the start-testing-configv2 branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants