Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send notification on VersionLockedError #4839

Merged
merged 1 commit into from Nov 1, 2018

Conversation

@humitos
Copy link
Member

@humitos humitos commented Oct 31, 2018

Instead of LockTimeout exception we are raising VersionLockedError instead. This change introduced a bug that notification started being sent again when a Version was locked and this was really annoying.

Instead of LockTimeout exception we are raising VersionLockedError
instead. This change introduced a bug that notification started being
sent again when a Version was locked and this was really annoying.
@humitos humitos requested a review from Oct 31, 2018
Copy link
Member

@ericholscher ericholscher left a comment

👍 Definitely annoying to get alerts on locked versions. I wonder if we can do something a bit more robust here. Is it possible to check the failure content for Version Locked or similar? Or some kind of test to catch this?

@humitos
Copy link
Member Author

@humitos humitos commented Oct 31, 2018

I wonder if we can do something a bit more robust here. Is it possible to check the failure content for Version Locked or similar?

I made a mistake when refactoring. That was the problem.

Checking for a string will bring the same problems in the future. We will change it to "version locked" (lower case, or similar sentence but different) and we will have the same problem.

What we need here, it's a test case if we want to avoid this problem :) Opened: #4840 for this.

@humitos humitos merged commit 2662530 into master Nov 1, 2018
1 check passed
@humitos humitos deleted the humitos/notifications/version-locked branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants