Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form for adopting project a choice field #4841

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Oct 31, 2018

Related Issue: #4777

Final Result:

screenshot from 2018-11-01 01-13-14

@dojutsu-user dojutsu-user changed the title Make form adopting project choice field Make form for adopting project a choice field Oct 31, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 31, 2018

Codecov Report

Merging #4841 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #4841      +/-   ##
==========================================
- Coverage   76.27%   76.26%   -0.01%     
==========================================
  Files         158      158              
  Lines        9981     9986       +5     
  Branches     1261     1262       +1     
==========================================
+ Hits         7613     7616       +3     
- Misses       2024     2025       +1     
- Partials      344      345       +1
Impacted Files Coverage Δ
readthedocs/gold/views.py 66.17% <0%> (ø) ⬆️
readthedocs/gold/forms.py 94.54% <100%> (-3.46%) ⬇️

Copy link
Member

@ericholscher ericholscher left a comment

💯 Thanks!

@ericholscher ericholscher merged commit d7d03ef into readthedocs:master Nov 1, 2018
3 checks passed
@dojutsu-user dojutsu-user deleted the make-form-adopting-project-choice-field branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants