Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change project's VCS #4845

Merged
merged 2 commits into from Nov 1, 2018
Merged

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Nov 1, 2018

Fixes #4844
More background on #1170

So, previously this wasn't so important, users could just change the default_branch to whatever they want (master in this case). But, with #4710 they can't do that anymore and the only solution is to recreate the project.

I know this isn't a common case (changing VCS), but if the user chooses by mistake the wrong VCS when creating the project, then the user is in trouble.

@stsewd stsewd force-pushed the allow-change-vcs branch from 19ae374 to 629a5af Nov 1, 2018
@codecov
Copy link

@codecov codecov bot commented Nov 1, 2018

Codecov Report

Merging #4845 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4845      +/-   ##
==========================================
+ Coverage   76.27%   76.34%   +0.07%     
==========================================
  Files         158      158              
  Lines        9981     9981              
  Branches     1261     1260       -1     
==========================================
+ Hits         7613     7620       +7     
+ Misses       2024     2020       -4     
+ Partials      344      341       -3
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.5% <100%> (+1.49%) ⬆️

Copy link
Member

@ericholscher ericholscher left a comment

Makes sense. 👍

@ericholscher ericholscher merged commit 28773ee into readthedocs:master Nov 1, 2018
3 checks passed
@stsewd stsewd deleted the allow-change-vcs branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants